docs: an oversized upscale is capped, not refused - #68
Merged
Conversation
The Size limits section still described the VALIDATION_ERROR that used to come back. The job now renders the largest size that fits and logs what it did, so the docs described behaviour that no longer exists. Also notes that the limit is on output pixels rather than on the factor, which is what makes a large source cap below 2x, and that the 7B caps roughly 40% sooner than the 3B.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows rendobar/rendobar#465 and #467, which changed the behaviour after these docs shipped.
Was: an over-large request failed with
VALIDATION_ERRORbefore the model loaded.Now: it renders the largest size that fits, keeps the aspect ratio, and logs what it did.
Fixes three stale claims:
output.file.metarather than assuming the dimensions match the request.Also documents that
seedvr2-7bcaps roughly 40% sooner thanseedvr2-3b, per the per-checkpoint ceiling in #465.Validator: 22 files, all valid.